Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converts E2E tests to user journey tests & adds --no-progress flag for cleaner CI logs #581

Merged
merged 17 commits into from
Jul 2, 2022

Conversation

jeff-mccoy
Copy link
Contributor

@jeff-mccoy jeff-mccoy commented Jul 1, 2022

Migrate E2E tests to a journey-style E2E test suite that focuses on categories of behavior/interaction with Zarf. Tests are now grouped by either an outcome, i.e. "deploy the dos games" or a typical use of Zarf, "i.e." upload and interact with the git-server.

This PR also introduces the --no-progress flag to disable progress bars and spinners to keep logs more useful for CI.

NOTE: the E2E tests now execute against a single cluster much like a regular user might vs continually creating and destroying the Zarf assets in the cluster. This isn't without risk as the shared runners we use are limited to 2 CPU and 7 GBs of RAM so we have to be aware of resource constraints. For that reason each test setup dumps the current port bindings and cluster resource allocations.

jeff-mccoy added a commit that referenced this pull request Jul 1, 2022
jeff-mccoy added a commit that referenced this pull request Jul 1, 2022
@jeff-mccoy jeff-mccoy changed the title Create jeff-is-going-crazy.txt E2E Test Overhaul Jul 1, 2022
@jeff-mccoy jeff-mccoy marked this pull request as ready for review July 2, 2022 01:21
@jeff-mccoy jeff-mccoy requested a review from YrrepNoj July 2, 2022 01:31
@jeff-mccoy jeff-mccoy changed the title E2E Test Overhaul Converts E2E tests to user journey tests & adds --no-progress flag for cleaner CI logs Jul 2, 2022
.github/workflows/test-k3d.yml Outdated Show resolved Hide resolved
.github/workflows/test-k3s.yml Show resolved Hide resolved
src/test/e2e/common.go Show resolved Hide resolved
src/test/e2e/common.go Show resolved Hide resolved
@jeff-mccoy jeff-mccoy added this to the Zarf GA milestone Jul 2, 2022
Copy link
Contributor

@YrrepNoj YrrepNoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for breaking this out of your other PR. I'm super excited that the tests are running so quickly now.

@jeff-mccoy jeff-mccoy merged commit 375ac9c into master Jul 2, 2022
@jeff-mccoy jeff-mccoy deleted the sanity-check-tests branch July 2, 2022 04:10
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
…for cleaner CI logs (#581)

* initial test migration
* update helm releasename tests
* trace log data injection test
* cleanup test sequence & resource reqs for shared runners
* install kind directly vs helm action
* match kind install sequence
* add k8s resource dump for ci sanity in the future
* add --no-progress flag
* fix imports / types
* add CI for k3s in sudo
* use message.progress
* Match user journey from https://zarf.dev/install/
* try wrapping `uname -m` in sh command
* correct exec path for install test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants