-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converts E2E tests to user journey tests & adds --no-progress
flag for cleaner CI logs
#581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-mccoy
added a commit
that referenced
this pull request
Jul 1, 2022
jeff-mccoy
changed the title
E2E Test Overhaul
Converts E2E tests to user journey tests & adds Jul 2, 2022
--no-progress
flag for cleaner CI logs
YrrepNoj
suggested changes
Jul 2, 2022
YrrepNoj
approved these changes
Jul 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for breaking this out of your other PR. I'm super excited that the tests are running so quickly now.
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
…for cleaner CI logs (#581) * initial test migration * update helm releasename tests * trace log data injection test * cleanup test sequence & resource reqs for shared runners * install kind directly vs helm action * match kind install sequence * add k8s resource dump for ci sanity in the future * add --no-progress flag * fix imports / types * add CI for k3s in sudo * use message.progress * Match user journey from https://zarf.dev/install/ * try wrapping `uname -m` in sh command * correct exec path for install test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate E2E tests to a journey-style E2E test suite that focuses on categories of behavior/interaction with Zarf. Tests are now grouped by either an outcome, i.e. "deploy the dos games" or a typical use of Zarf, "i.e." upload and interact with the git-server.
This PR also introduces the
--no-progress
flag to disable progress bars and spinners to keep logs more useful for CI.NOTE: the E2E tests now execute against a single cluster much like a regular user might vs continually creating and destroying the Zarf assets in the cluster. This isn't without risk as the shared runners we use are limited to 2 CPU and 7 GBs of RAM so we have to be aware of resource constraints. For that reason each test setup dumps the current port bindings and cluster resource allocations.