Fix registry user in credentials output

[rodneyxr]

Description

Referenced config.ZarfRegistryPushUser instead of the hardcoded zarf-push-user which was incorrectly being displayed in the credentials output after a zarf init.

Related Issue

Fixes #577

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist before merging

• Tests have been added/updated as necessary (add the needs-tests label)
• Documentation has been updated as necessary (add the needs-docs label)
• An ADR has been written as necessary (add the needs-adr label) [ 1 2 3 ]
• (Optional) Changes have been linted locally with golangci-lint. (NOTE: We haven't turned on lint checks in the pipeline yet so linting may be hard if it shows a lot of lint errors in places that weren't touched by changes. Thus, linting is optional right now.)

[rodneyxr]

What is the issue with Error: needs-git-sign-off label is banned in the enforce-labels job? I thought I signed my commit correctly 😞

[jeff-mccoy]

Sorry that's really confusing. We require a core-member sign-off of all third party contributions. One of us needs to re-sign your commits and a different member do the approval. You'll still get authorship for the commit, but that way we can track back our reviewers to touching every piece of code. I'll do the sign-off later today.

[jeff-mccoy]

If you hover over the label we try to explain this, but clearly should have something on PR open that let's you know the process.

[rodneyxr]

If you hover over the label we try to explain this, but clearly should have something on PR open that let's you know the process.

Ah I read that incorrectly... I thought it said I had to sign my commits. Thanks for the info!

[jeff-mccoy]

@YrrepNoj sign-off complete, will leave to you for final review. Thanks @rodneyxr for the PR!