breaking change: include sanitized hostname in offline registry path #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ages-from-insecure-repo
7 tasks
…ages-from-insecure-repo
…ages-from-insecure-repo
…ages-from-insecure-repo
…ages-from-insecure-repo
…ages-from-insecure-repo
…ages-from-insecure-repo
|
Closing in favor of #666 |
jeff-mccoy
deleted the
561-cant-deploy-zarf-package-built-with-images-from-insecure-repo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include the hostname in the image path for offline image pushes. Requires an update to zarf agent as well.
converts localhost:5000/zarf-game:multi-tile-dark -> 127.0.0.1:45001/localhost.5000/zarf-game:multi-tile-dark on push and 127.0.0.1:31999/localhost.5000/zarf-game:multi-tile-dark on pull via the Zarf Agent
Fixes #561
Type of change