-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug Message Cleanup #511
Conversation
a5dfba5
to
d5446f4
Compare
Right now we can do |
dcbc19b
to
1ee2c13
Compare
b02d3bc
to
578990e
Compare
578990e
to
98ac59e
Compare
d854546
to
92b729a
Compare
92b729a
to
82529fb
Compare
All prior PRs are now merged, all that is left is some debug message cleanup 😆 |
All resolved/handled in separate PRs that are now merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grep -rnsI "%v" . --include="*.go"
returns a handful of places that are still using %v
instead of %#v
None of them are logging anything more complex than a slice so it probably doesn't matter but it might be nice to update them just for consistency sake 🤷
Yeah I think those were missed with other merges, can update them too |
All requested changes made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
No description provided.