Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug Message Cleanup #511

Merged
merged 9 commits into from
Jul 18, 2022
Merged

Debug Message Cleanup #511

merged 9 commits into from
Jul 18, 2022

Conversation

jeff-mccoy
Copy link
Contributor

No description provided.

@jeff-mccoy jeff-mccoy added documentation 📘 Improvements or additions to documentation enhancement ✨ New feature or request packager labels Jun 11, 2022
src/internal/k8s/tunnel.go Outdated Show resolved Hide resolved
examples/tiny-kafka/zarf.yaml Outdated Show resolved Hide resolved
examples/istio-with-separate-cert/README.md Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
src/cmd/package.go Outdated Show resolved Hide resolved
examples/Vagrantfile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@YrrepNoj
Copy link
Contributor

Right now we can do zarf package deploy path/to/package. I think it would be good UX if we were consistent and gave users the ability to do zarf init path/to/package as well.

@jeff-mccoy jeff-mccoy marked this pull request as ready for review June 30, 2022 05:35
@jeff-mccoy jeff-mccoy marked this pull request as draft July 3, 2022 19:57
@jeff-mccoy jeff-mccoy force-pushed the ux-improvements branch 2 times, most recently from b02d3bc to 578990e Compare July 11, 2022 21:02
@jeff-mccoy jeff-mccoy changed the title Ux improvements Debug Message Cleanup Jul 18, 2022
@jeff-mccoy jeff-mccoy marked this pull request as ready for review July 18, 2022 18:42
@jeff-mccoy jeff-mccoy added tech-debt and removed documentation 📘 Improvements or additions to documentation enhancement ✨ New feature or request packager labels Jul 18, 2022
@jeff-mccoy
Copy link
Contributor Author

All prior PRs are now merged, all that is left is some debug message cleanup 😆

@jeff-mccoy jeff-mccoy requested a review from YrrepNoj July 18, 2022 18:46
@jeff-mccoy jeff-mccoy dismissed YrrepNoj’s stale review July 18, 2022 18:47

All resolved/handled in separate PRs that are now merged

@jeff-mccoy jeff-mccoy requested a review from Racer159 July 18, 2022 18:59
src/internal/k8s/secrets.go Outdated Show resolved Hide resolved
src/internal/k8s/state.go Show resolved Hide resolved
src/internal/k8s/state.go Outdated Show resolved Hide resolved
src/internal/git/utils.go Outdated Show resolved Hide resolved
Copy link
Contributor

@YrrepNoj YrrepNoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grep -rnsI "%v" . --include="*.go" returns a handful of places that are still using %v instead of %#v

None of them are logging anything more complex than a slice so it probably doesn't matter but it might be nice to update them just for consistency sake 🤷

@jeff-mccoy
Copy link
Contributor Author

grep -rnsI "%v" . --include="*.go" returns a handful of places that are still using %v instead of %#v

None of them are logging anything more complex than a slice so it probably doesn't matter but it might be nice to update them just for consistency sake 🤷

Yeah I think those were missed with other merges, can update them too

@jeff-mccoy
Copy link
Contributor Author

Screen Shot 2022-07-18 at 5 05 15 PM

@jeff-mccoy
Copy link
Contributor Author

All requested changes made

@jeff-mccoy jeff-mccoy requested review from Racer159 and YrrepNoj July 18, 2022 22:20
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jeff-mccoy jeff-mccoy merged commit a2ff83c into master Jul 18, 2022
@jeff-mccoy jeff-mccoy deleted the ux-improvements branch July 18, 2022 22:51
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants