implement component choice groups #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Prompt for choosing which component to deploy: After selection: Error message if attempting to specify more than one component from a choice group: |
|
Updated zarf init credential examples:
|
YrrepNoj
suggested changes
May 23, 2022
|
Unique component name enforcement
|
YrrepNoj
approved these changes
May 24, 2022
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
* implement component choice groups * fix test & handle default values w/--confirm again * add test case to ensure second component was not created when first is chosen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a new deployment flow for components where the package author needs the ability to group a set of components and only allow a single one in the group to be deployed. Enforcement for CLI flags also exists to prevent a CLI flag from deploying multiple components from the same group. This PR also cleans up the business logic used to validate and select components to hopefully be more readable. An example was added and Big Bang Core was moved to packages with a demonstration of this usage as well. Finally small pterm improvements were made for readability/improved flow including only showing credentials on init for components that were actually deployed.
Fixes #487
Type of change
Checklist before merging
needs-testslabel)needs-docslabel)