Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use registry secrets #478

Merged
merged 1 commit into from
May 7, 2022
Merged

Conversation

vyta
Copy link
Contributor

@vyta vyta commented May 6, 2022

Description

Related Issue

Fixes #477

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist before merging

  • (Optional) Changes have been linted locally with golangci-lint. (NOTE: We haven't turned on lint checks in the pipeline yet so linting may be hard if it shows a lot of lint errors in places that weren't touched by changes. Thus, linting is optional right now.)

YrrepNoj
YrrepNoj previously approved these changes May 6, 2022
Copy link
Contributor

@YrrepNoj YrrepNoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Our internal team rules require two approvals for outside contributors so once someone else on the team gives this a look over we'll merge it in. Thanks again :)

Signed-off-by: Jeff McCoy <[email protected]>
Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm.

@jeff-mccoy
Copy link
Contributor

@YrrepNoj / @RothAndrew I did a git sign-off amendment as part of the process we discussed for 3rd-party contributors. Based on how github treats that I think we need to update the contributor guides to have the first internal team member do a git commit --amend --signoff and then require another team member to do the PR approval. Thoughts?

@YrrepNoj
Copy link
Contributor

YrrepNoj commented May 7, 2022

@jeff-mccoy That makes sense to me, we should definitely update our contributor guide to explain why we're going the extra step to signoff on the commits though

@jeff-mccoy jeff-mccoy enabled auto-merge (squash) May 7, 2022 06:57
@jeff-mccoy jeff-mccoy merged commit a2fe6f9 into zarf-dev:master May 7, 2022
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Registry Secrets When Deploying Packages
3 participants