Fallback to host-provided git on clone failure during package create #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-mccoy
added
packager
bug 🐞
|
Successful clone via fallback: Failed clone (invalid git url) via fallback: |
YrrepNoj
suggested changes
May 2, 2022
YrrepNoj
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows for graceful failure on various go-git cloning issues related to authentication, git protocol, etc during the
zarf package createexecution. On a clone failure, the git package will attempt to call the host-basedgit clonebefore completely failing. Note that due to the format of Azure http git clone urls, this command will not support single-tag/single-depth clones in this PR.Related Issue
Related to #456
Fixes #417
Type of change
Checklist before merging