Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

338 configurable script timeout #459

Merged
merged 4 commits into from
Apr 25, 2022
Merged

338 configurable script timeout #459

merged 4 commits into from
Apr 25, 2022

Conversation

jeff-mccoy
Copy link
Contributor

@jeff-mccoy jeff-mccoy commented Apr 24, 2022 •
edited
Loading

Add the ability to define a script timeout length in seconds and show logs inline. Also added an EKS example use-case for when this would be useful

Example:

  - name: example-one-hour-timeout-with-show-logs
    scripts:
      timeout: 3600
      showOutput: true
      before:
        - "some-long-running-command-here"

Fixes #338

Type of change

  • New feature (non-breaking change which adds functionality)

@jeff-mccoy jeff-mccoy added enhancement ✨ New feature or request packager needs-tests PR Label - Tests required to merge labels Apr 24, 2022
@jeff-mccoy jeff-mccoy added this to the Zarf GA milestone Apr 24, 2022
@jeff-mccoy jeff-mccoy force-pushed the 338-configurable-script-timeout branch from 5f43647 to cc39ab7 Compare April 25, 2022 07:47
@jeff-mccoy jeff-mccoy removed the needs-tests PR Label - Tests required to merge label Apr 25, 2022
@jeff-mccoy jeff-mccoy force-pushed the 338-configurable-script-timeout branch from cc39ab7 to fc8a55a Compare April 25, 2022 08:05
@jeff-mccoy jeff-mccoy requested a review from YrrepNoj April 25, 2022 08:24
YrrepNoj
YrrepNoj reviewed Apr 25, 2022
View reviewed changes
zarf.schema.json Outdated Show resolved Hide resolved
YrrepNoj
YrrepNoj previously approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@YrrepNoj YrrepNoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a few optional suggestions for changes/new tasks that you can take as you see fit.

YrrepNoj
YrrepNoj approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@YrrepNoj YrrepNoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! LGTM.

@jeff-mccoy jeff-mccoy merged commit 8c4ad3d into master Apr 25, 2022
@jeff-mccoy jeff-mccoy deleted the 338-configurable-script-timeout branch April 25, 2022 16:42
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
@jeff-mccoy
338 configurable script timeout (#459)
0463f0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RothAndrew RothAndrew RothAndrew left review comments

@YrrepNoj YrrepNoj YrrepNoj approved these changes

Assignees
No one assigned
Labels
enhancement ✨ New feature or request
Projects
None yet
Milestone
Zarf GA
Development

Successfully merging this pull request may close these issues.

Configurable Script Timeout
3 participants
@jeff-mccoy @RothAndrew @YrrepNoj