Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust Binary Checks SHA256 #449

Merged
merged 7 commits into from
Apr 20, 2022
Merged

Rust Binary Checks SHA256 #449

merged 7 commits into from
Apr 20, 2022

Conversation

YrrepNoj
Copy link
Contributor

@YrrepNoj YrrepNoj commented Apr 18, 2022

When deploying an init package and performing the registry injection the Go CLI will dynamically calculate the payload sha256sum and provide it to the Rust injector binary to validate before installing the registry onto the cluster.

@YrrepNoj YrrepNoj force-pushed the 380-rust-binary-sha256 branch from 9abceab to c00a550 Compare April 18, 2022 19:17
@YrrepNoj YrrepNoj force-pushed the 380-rust-binary-sha256 branch from ea98d0d to b36dcfb Compare April 20, 2022 05:30
@YrrepNoj YrrepNoj marked this pull request as ready for review April 20, 2022 05:41
@YrrepNoj YrrepNoj requested a review from jeff-mccoy April 20, 2022 05:41
@YrrepNoj
Copy link
Contributor Author

This PR might look small but I promise I spent HOURS stumbling around learning all the wrong ways to do things in Rust 🤣

@jeff-mccoy jeff-mccoy force-pushed the 380-rust-binary-sha256 branch from 2c204ac to 3805e1a Compare April 20, 2022 07:08
@jeff-mccoy jeff-mccoy force-pushed the 380-rust-binary-sha256 branch from 81e119e to 7bd22a7 Compare April 20, 2022 07:32
@jeff-mccoy
Copy link
Contributor

Had to do a little cleanup so we could push through the outstanding rust release issues / test this properly.

Screen Shot 2022-04-20 at 3 01 41 AM

Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jeff-mccoy jeff-mccoy enabled auto-merge (squash) April 20, 2022 08:11
@jeff-mccoy jeff-mccoy merged commit 0880709 into master Apr 20, 2022
@jeff-mccoy jeff-mccoy deleted the 380-rust-binary-sha256 branch April 20, 2022 08:14
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
* add shasum check of init payload
* fix path to rust injector in workflow
* update zarf-ijector to version that checks sha
* switch to govcloud KMS
* update rust injector cargo version
* add cosign annotations
* include github url in release-engineer annotation

Co-authored-by: Jeff McCoy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants