-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds zarf cache flag #446
adds zarf cache flag #446
Conversation
efe2a22
to
8a6d325
Compare
Currently, the Zarf image cache resides in the home directory and this PR adds the option to put the cache in a subpath within the home directory. Would we like the option to put the image cache outside of the home directory? |
8a6d325
to
d618d1d
Compare
@YrrepNoj you were working with someone on something kinda-adjacent to this kind of thing right? IIRC they had very little space on their root drive (where the home directory is mounted) but they had a separate filesystem mount that had tons of space. Given that, perhaps the user should be able to specify anywhere they want, rather than just somewhere inside their home directory. |
d618d1d
to
6783714
Compare
Thanks @UncleGedd, this is a helpful PR. I think we should discuss moving the flag down to |
Easy fix! Will update and add an e2e test for |
018d0e1
to
897cbe8
Compare
897cbe8
to
ca1b754
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good and is a valuable addition, only comment is whether the regex for path detection is the best way to do that vs some path function.
Description
Adds a
zarf-cache
flag to specify where images are stored on a user's machine.Related Issue
Fixes issue #402
Type of change