Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pre-commit run -a #445

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Run pre-commit run -a #445

merged 1 commit into from
Apr 14, 2022

Conversation

RothAndrew
Copy link
Contributor

Description

Run SKIP=golangci-lint pre-commit run -a on the whole repo and fix what breaks

Related Issue

none

Type of change

  • Refactor (non-breaking change which doesn't change existing functionality)

Checklist before merging

  • Tests have been added/updated as necessary (add the needs-tests label)
  • Documentation has been updated as necessary (add the needs-docs label)
  • An ADR has been written as necessary (add the needs-adr label) [ 1 2 3 ]
  • (Optional) Changes have been linted locally with golangci-lint. (NOTE: We haven't turned on lint checks in the pipeline yet so linting may be hard if it shows a lot of lint errors in places that weren't touched by changes. Thus, linting is optional right now.)

@RothAndrew RothAndrew self-assigned this Apr 14, 2022
@RothAndrew RothAndrew enabled auto-merge (squash) April 14, 2022 18:56
Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @RothAndrew lgtm

@RothAndrew RothAndrew merged commit 677bb62 into master Apr 14, 2022
@RothAndrew RothAndrew deleted the feature/run-pre-commit branch April 14, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants