Make Data Injections Happen asyc w/ Component Deployment #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update data-injection demo such that it uses an init container, which is closer to what a realistic scenario would use.
…ta-injection-example' into fix/data-injection-race-condition
jeff-mccoy
previously approved these changes
Mar 30, 2022
RothAndrew
reviewed
Mar 30, 2022
|
update the schema file? |
|
@jeff-mccoy I thought this update would mean that we wouldn't need the loop when checking the data-injection results but that doesn't seem to be the case. |
jeff-mccoy
previously approved these changes
Mar 30, 2022
RothAndrew
reviewed
Mar 30, 2022
RothAndrew
previously approved these changes
Mar 30, 2022
RothAndrew
previously approved these changes
Mar 30, 2022
YrrepNoj
force-pushed
the
fix/data-injection-race-condition
branch
from
1c2b72a to
09e0882
Compare
|
For some reason, the k8s api must be doing some weird cashing things. The exec is not showing files in the volume that should be there because:
Because of that I'm going to add the retry loop to the test. 👎 |
jeff-mccoy
approved these changes
Mar 31, 2022
7 tasks
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
- Breaking Change: move "data" to components -> "dataInjections" - Update data-injection example to use initContainer & pod variants for E2E - Cleanup E2E flow for data injection tests - Fix issues with race conditions involving initContainers data injections & Helm wait - Way too much work on making tests not cry with async ops for data injection Co-authored-by: Andy Roth <[email protected]> Co-authored-by: Jeff McCoy <[email protected]> Co-authored-by: Jon Perry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Data injections used to operate after all the components have been deployed. This is an issue when apps are expecting data before they report themselves as healthy. When this happens the pod is never able to report healthy because their init container is waiting for the data which isn't getting injected because the pods are not reporting healthy yet. A un-fun loop.
This PR moves the data-injection operation at the same time as the component deployment and has the injection happen as a go routine that way once the pods come up the data will be injected in the background.
Related Issue
Fixes #423
Type of change
Checklist before merging
needs-testslabel)needs-docslabel)