Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer test cleanup function #397

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Defer test cleanup function #397

merged 2 commits into from
Mar 15, 2022

Conversation

YrrepNoj
Copy link
Contributor

@YrrepNoj YrrepNoj commented Mar 14, 2022

Description

use defer to ensure the cleanup function gets run after each test case, even (especially..) if the case failed a require check.

Related Issue

Fixes #396

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@YrrepNoj YrrepNoj requested a review from jeff-mccoy March 14, 2022 19:11
jeff-mccoy
jeff-mccoy previously approved these changes Mar 14, 2022
@jeff-mccoy jeff-mccoy merged commit 6801885 into master Mar 15, 2022
@jeff-mccoy jeff-mccoy deleted the bugfix/defer-test-cleanup branch March 15, 2022 00:36
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E tests don't cleanup properly on failure.
2 participants