Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: print image list without package yaml when using --image-list flag with inspect #3384

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

AustinAbro321
Copy link
Contributor

@AustinAbro321 AustinAbro321 commented Jan 7, 2025

Description

In #2990 we changed the zarf package inspect --list-images logic to print both the image list and the color printed yaml file. This reverts back to the old behavior of only printing the image list, which should make it easier for users to view / parse this list.

Related Issue

Fixes #3374

Checklist before merging

@AustinAbro321 AustinAbro321 requested review from a team as code owners January 7, 2025 19:12
Copy link

netlify bot commented Jan 7, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit a3f0776
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/677d7db2ca35fb00085e5da6

@AustinAbro321 AustinAbro321 changed the title fix: package inspect --image list should only print the image list fix: change package inspect --image-list to print the image list without the package yaml Jan 7, 2025
@AustinAbro321 AustinAbro321 changed the title fix: change package inspect --image-list to print the image list without the package yaml fix: print image list without package yaml when using --image-list flag with inspect Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager2/inspect.go 0.00% 7 Missing ⚠️
src/cmd/package.go 0.00% 5 Missing ⚠️
Files with missing lines Coverage Δ
src/cmd/package.go 0.00% <0.00%> (ø)
src/internal/packager2/inspect.go 0.00% <0.00%> (ø)

Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit a10e196 Jan 8, 2025
26 checks passed
@AustinAbro321 AustinAbro321 deleted the print-image-list-without-package-yaml branch January 8, 2025 12:52
@philiversen
Copy link

Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected output for 'zarf package inspect --list-images'
3 participants