fix: check public key for signed packages during zarf package pull #3347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
✅ Deploy Preview for zarf-docs canceled.
|
Signed-off-by: Austin Abro <[email protected]>
Codecov ReportAttention: Patch coverage is
|
AustinAbro321
commented
Dec 18, 2024
There was a problem hiding this comment.
refactored this test to create and publish the package to an in memory registry, this way we don't rely on external private keys or external infrastructure. Added a test to ensure pulling the package without a public key fails and verified that it does fail on main.
AustinAbro321
changed the title
Signed-off-by: Austin Abro <[email protected]>
mkcp
approved these changes
Dec 18, 2024
| func (suite *PullInspectTestSuite) TearDownSuite() { | ||
| local := fmt.Sprintf("zarf-package-dos-games-%s-1.0.0.tar.zst", e2e.Arch) | ||
| e2e.CleanFiles(suite.T(), local) | ||
| suite.Reference.Registry = testutil.SetupInMemoryRegistry(testutil.TestContext(suite.T()), suite.T(), 31888) |
There was a problem hiding this comment.
TIL testutil.SetupInMemoryRegistry
There was a problem hiding this comment.
It's very useful for unit tests as well, once the create refactor is merged, we should be able to make tests for publish and pull with unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
zarf package pullignores the--keywhen pulling signed packagesRelated Issue
Fixes #3346
Checklist before merging