feat: add the new logger through Zarf wherever it is missing #3265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Abro <[email protected]>
✅ Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AustinAbro321
changed the title
AustinAbro321
changed the title
Signed-off-by: Austin Abro <[email protected]>
AustinAbro321
commented
Nov 21, 2024
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
mkcp
previously approved these changes
Nov 21, 2024
| @@ -25,6 +25,7 @@ func SelectOptionalComponent(component v1alpha1.ZarfComponent) (bool, error) { | |||
| return false, err | |||
| } | |||
| if component.Description != "" { | |||
| // TODO (@austinabro321) once we move interactiveness to CLI level we should replace this with logger.Info | |||
Signed-off-by: Austin Abro <[email protected]>
mkcp
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Went back through the Zarf codebase and added the new logging commands to places where we may have missed on the first pass through. There are some errors that we will never reach or are very unlikely to reach where we run a
message.Debug. In these situations, I just replaced message with the new logger now.Fixes #2576
Checklist before merging