Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Helm max history to limit secret creation #3249

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

phillebaba
Copy link
Member

Description

This change limits the Helm history secrets to 5 in an attempt to stop massive amounts of secrets to be created over a long time.

Related Issue

Fixes #3242

Checklist before merging

@phillebaba phillebaba requested review from a team as code owners November 20, 2024 09:18
Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit e86aae7
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/673f556e3e0fe5000873b114

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager/helm/chart.go 0.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
src/internal/packager/helm/chart.go 12.30% <0.00%> (-0.10%) ⬇️

... and 3 files with indirect coverage changes


🚨 Try these New Features:

@phillebaba phillebaba force-pushed the fix/helm-release-secret branch from 82784bb to 3b9a36e Compare November 20, 2024 14:05
@phillebaba phillebaba force-pushed the fix/helm-release-secret branch 3 times, most recently from 21dddee to 88eaf26 Compare November 21, 2024 14:59
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 7aa3224 Nov 21, 2024
26 checks passed
@AustinAbro321 AustinAbro321 deleted the fix/helm-release-secret branch November 21, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Would like the ability to define a helm version retention threshold like a MaxHistory
2 participants