Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement new logger for Zarf connect #3208

Merged
merged 3 commits into from
Nov 7, 2024
Merged

feat: implement new logger for Zarf connect #3208

merged 3 commits into from
Nov 7, 2024

Conversation

AustinAbro321
Copy link
Contributor

Description

This implements slog for connect

Related Issue

Relates to #2576

Checklist before merging

@AustinAbro321
connect slog
73a248f 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321 AustinAbro321 requested review from a team as code owners November 6, 2024 21:35
@netlify Netlify
Copy link

netlify bot commented Nov 6, 2024 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 7f1d096
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/672ce39653928f0008f144fe

@codecov Codecov
Copy link

codecov bot commented Nov 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/cmd/connect.go 0.00% 5 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/packager/prepare.go 53.46% <100.00%> (ø)
src/cmd/connect.go 0.00% <0.00%> (ø)

... and 11 files with indirect coverage changes

@AustinAbro321
slog style
7caf0be 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321
get rid of logger enabled if
7f1d096 
Signed-off-by: Austin Abro <[email protected]>
mkcp
mkcp approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - gj reaching out for more context

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit bc9b634 Nov 7, 2024
26 checks passed
@AustinAbro321 AustinAbro321 deleted the slog-connect branch November 7, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkcp mkcp mkcp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AustinAbro321 @mkcp