Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fear: allow versioning of init packages outside of binary version #3169

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

a1994sc
Copy link
Contributor

@a1994sc a1994sc commented Oct 31, 2024

Description

Allows for the versioning of ZarfInitConfig by setting .metadata.version; it defaults to using the existing logic for setting the version to whatever the binary version is.

Related Issue

Fixes #3148

Checklist before merging

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 5aa6f33
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/67255bff7408fe0008b09dfc

src/config/lang/english.go Outdated Show resolved Hide resolved
src/cmd/initialize.go Outdated Show resolved Hide resolved
@a1994sc a1994sc force-pushed the init-pkgs-version branch 2 times, most recently from 30a660b to 928ccd8 Compare November 1, 2024 22:50
@a1994sc a1994sc marked this pull request as ready for review November 1, 2024 22:53
@a1994sc a1994sc requested review from a team as code owners November 1, 2024 22:53
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/packager/creator/utils.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/packager/creator/utils.go 18.18% <0.00%> (ø)

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Nov 4, 2024
Merged via the queue into zarf-dev:main with commit 3b873c8 Nov 4, 2024
26 checks passed
Jneville0815 pushed a commit to radiusmethod/zarf that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow ZarfInitConfig to be versioned outside of being tied to binary version
2 participants