-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issue where kustomization files are empty #3094
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs canceled.
|
a1994sc
commented
Oct 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
@a1994sc how much effort do you think it would be to add a test for this fix? |
I would have look into how the existing testing is done, so I'm unsure |
Signed-off-by: Allen Conlon <[email protected]> - Includes unit test for kustomization
@phillebaba I updated the PR with a basic unit test. |
AustinAbro321
approved these changes
Oct 30, 2024
Jneville0815
pushed a commit
to radiusmethod/zarf
that referenced
this pull request
Dec 12, 2024
Co-authored-by: Austin Abro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a where
zarf
is unable to properly discover the images from a kustomization file.The culprit from my testing seems to be cause by
f
andnewDestination
being the same values when callinghelpers.CreatePathAndCopy
hereThat function, found here, basically copies a file from one path to another, however there is no check if the
source
anddestination
are same values. This causes the resulting file to be empty.The change in my PR uses the
temp
folder already created byzarf
to make sure that source and destination files are different, preventing an empty file from being scanned.Related Issue
Fixes #3065
Checklist before merging