-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove component webhooks #3066
Conversation
Signed-off-by: Austin Abro <[email protected]>
✅ Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
|
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
@@ -183,13 +175,6 @@ func (p *Packager) deployComponents(ctx context.Context) ([]types.DeployedCompon | |||
deployedComponents = append(deployedComponents, deployedComponent) | |||
idx := len(deployedComponents) - 1 | |||
|
|||
// Update the package secret to indicate that we are attempting to deploy this component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we no longer have component webhooks there is no reason for us to update the secret before the component is deployed
Signed-off-by: Austin Abro <[email protected]>
This seems to all look good. My only question is why we are remove the generation counter? Is it specific to the component webhook only? |
@phillebaba It's in the package secret so technically others could look at it, but it was added in Zarf so component webhooks could use it. I noticed that it was added in the same PR that introduced component webhooks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Austin Abro <[email protected]> Signed-off-by: Micah Nagel <[email protected]>
Signed-off-by: Austin Abro <[email protected]> Signed-off-by: ittacco <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Description
This removes component webhooks. An alpha feature that did not see significant adoption
This comes with changes for the the secret generated for each package on deploy. The secret is no longer created / updated at the start and end of the component deploy, now it is only updated at the start. This also changes the
deployedComponents
object within that secret. Status and observed generation were introduced for component webhooks so they are removed. ThedeployedComponent
json changes from thisto this
Related Issue
Fixes #2610
Checklist before merging