fix: support registry override for dev deploy (yolo) #3064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs canceled.
|
mjnagel
force-pushed
the
dev-deploy-registry
branch
from
5047594 to
d893b60
Compare
mjnagel
commented
Oct 3, 2024
mjnagel
changed the title
mjnagel
commented
Oct 21, 2024
Comment on lines
+60
to
+61
| stdOut, stdErr, err = e2e.Zarf(t, "tools", "kubectl", "delete", "namespace", "dos-games") | ||
| require.NoError(t, err, stdOut, stdErr) |
There was a problem hiding this comment.
I might just be crazy but I don't think package remove works on something that was dev deployed, so I switched this to just delete the namespace instead...
mjnagel
force-pushed
the
dev-deploy-registry
branch
from
2164670 to
4b0ae4b
Compare
Signed-off-by: Micah Nagel <[email protected]>
mjnagel
force-pushed
the
dev-deploy-registry
branch
from
4b0ae4b to
9c3c0f5
Compare
schristoff
approved these changes
Oct 22, 2024
Codecov ReportAttention: Patch coverage is
|
5 tasks
Jneville0815
pushed a commit
to radiusmethod/zarf
that referenced
this pull request
Dec 12, 2024
Signed-off-by: Micah Nagel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new hidden flag
--registry-urlwhich can be used on dev deploy (yolo only) to set the value to use forZARF_REGISTRY.Related Issue
Fixes #2713
Checklist before merging