refactor: skeleton creator #3042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs canceled.
|
Codecov ReportAttention: Patch coverage is
|
phillebaba
force-pushed
the
refactor/creator
branch
20 times, most recently
from
8304cfd to
e29a2ec
Compare
phillebaba
force-pushed
the
refactor/creator
branch
4 times, most recently
from
a86edd5 to
63c5a9f
Compare
phillebaba
force-pushed
the
refactor/creator
branch
3 times, most recently
from
9b415b0 to
032ce43
Compare
schristoff
reviewed
Oct 7, 2024
schristoff
reviewed
Oct 7, 2024
phillebaba
commented
Oct 7, 2024
schristoff
reviewed
Oct 7, 2024
schristoff
reviewed
Oct 8, 2024
src/pkg/packager/publish.go
Outdated
| @@ -48,26 +50,36 @@ func (p *Packager) Publish(ctx context.Context) (err error) { | |||
| } | |||
|
|
|||
| if p.cfg.CreateOpts.IsSkeleton { | |||
There was a problem hiding this comment.
Does this have to be changed?
There was a problem hiding this comment.
No we can leave changing this until after publish has been refactored if you prefer.
There was a problem hiding this comment.
I think that would be best
phillebaba
force-pushed
the
refactor/creator
branch
5 times, most recently
from
39624a7 to
88cad84
Compare
schristoff
previously approved these changes
Oct 8, 2024
phillebaba
force-pushed
the
refactor/creator
branch
from
88cad84 to
9f1f383
Compare
Signed-off-by: Philip Laine <[email protected]>
phillebaba
force-pushed
the
refactor/creator
branch
from
9f1f383 to
2ceb476
Compare
schristoff
approved these changes
Oct 8, 2024
mjnagel
pushed a commit
to mjnagel/zarf
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Philip Laine <[email protected]> Signed-off-by: Micah Nagel <[email protected]>
ittacco
pushed a commit
to ittacco/zarf
that referenced
this pull request
Nov 9, 2024
Signed-off-by: Philip Laine <[email protected]> Signed-off-by: ittacco <[email protected]>
Jneville0815
pushed a commit
to radiusmethod/zarf
that referenced
this pull request
Dec 12, 2024
Signed-off-by: Philip Laine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors skeleton creator.
A major feature of the refactor is that the implementation no longer requires sitting in the correct directory to build.
This change also limits imports to a single level. This means that it is no longer possible to import n levels of local skeleton packages anymore.
Related Issue
Relates to #2969
Checklist before merging