test: fix external git flake #3039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
✅ Deploy Preview for zarf-docs canceled.
|
Signed-off-by: Austin Abro <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
…o fix-external-git-flake
mkcp
approved these changes
Sep 26, 2024
ittacco
pushed a commit
to ittacco/zarf
that referenced
this pull request
Nov 9, 2024
Signed-off-by: Austin Abro <[email protected]> Signed-off-by: ittacco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hard to prove definitively that this will fix the flake, but it does seem like there is at least an issue with the logic of wait check currently.
Related Issue
Fixes #3024
^ I figure if it doesn't fix it we can re-open the issue
Checklist before merging