-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use /usr/sbin
instead of /usr/local/bin
to accommodate RHEL
#300
Conversation
/test all |
According to this I'm concerned about putting stuff in |
I don't think it matters much if you remember this is for appliance mode only, k3s will be a boot item as well. If /usr/sbin is always in the rhel path (note that link was for Ubuntu, which doesn't have this issue), then that's probably fine. I'm not certain that's the case but am fairly certain that /sbin or /bin always is regardless of the os. We'd probably want to verify running as root vs sudo too since this is really an env variable issue. Alternatively, we could just add /usr/local/bin to the path as an env variable on exec instead. |
My assumption is that the Given this. I propose we go with |
Works for me |
2c844de
to
f39fe1d
Compare
Funnily enough (at least on the Vagrant rhel8) |
f39fe1d
to
af45273
Compare
/test all |
rm -f /usr/sbin/ctr | ||
rm -f /usr/sbin/crictl | ||
rm -f /usr/sbin/kubectl | ||
rm -f /usr/sbin/k9s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know if it matters but this line shouldn't exist anymore as we don't install k9s separately now. Was missed during #237.
/test all |
/usr/sbin
instead of /usr/local/bin
to accommodate RHEL
Closes #296