Fix issue where --confirm flag isn't always respected.
#271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 4, 2022
|
@RothAndrew Sorry what was the point in making this instead of #252? And I believe this will fix the issue but I would like to write an e2e test just to have some form of proof for the future. I can do that today. |
|
@YrrepNoj after looking at it again, there wasn't one. I was getting hit by this bug a bunch on Friday and it was annoying me. #252 looked much bigger than it does now, but thinking about it again that was probably just git merge tree stuff, since #252 is super small now just like this one. I'll close this once since it is a duplicate of what #252 is already doing. |
RothAndrew
deleted the
feature/multi-distro-support-fix-issue-with-confirm-flag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this can take the place of #252 and will fix #200 once #237 is merged