Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle panic during checksum validation #2262

Merged
merged 2 commits into from
Jan 29, 2024
Merged

fix: handle panic during checksum validation #2262

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea0cf2f
fix: handle panic during checksum validation
mjnagel Jan 26, 2024
ac31e69
Update src/pkg/packager/sources/validate.go
mjnagel Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/pkg/packager/sources/validate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,17 @@ func ValidatePackageIntegrity(loaded *layout.PackagePaths, aggregateChecksum str
checkedMap[loaded.Signature] = true

err = lineByLine(checksumPath, func(line string) error {
// If the line is empty (i.e. there is no checksum) simply skip it - this can result from a package with no images/components
if line == "" {
return nil
}

split := strings.Split(line, " ")
// If the line is not splitable into two pieces the file is likely corrupted
if len(split) != 2 {
return fmt.Errorf("invalid checksum line: %s", line)
}

sha := split[0]
rel := split[1]

Expand Down
Loading