Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-progress to wait-for sub command #2093

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

WeaponX314
Copy link
Contributor

@WeaponX314 WeaponX314 commented Oct 23, 2023

Description

Simply adds --no-progress option to zarf tools wait-for.
Wanted this for cases where zarf tools wait-for is used to wait on nodes joining, can take a couple of minutes depending on the workflow and the spinners would flood the log a couple times per second.

Fixes #2091

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit b7f3492
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/65383508126022000892284b
😎 Deploy Preview https://deploy-preview-2093--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@WeaponX314 WeaponX314 changed the title --no-progress flag for wait cmd Add --no-progress to wait-for sub command Oct 23, 2023
@WeaponX314 WeaponX314 marked this pull request as ready for review October 23, 2023 01:26
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Racer159 Racer159 merged commit 4478cd6 into zarf-dev:main Oct 24, 2023
@WeaponX314 WeaponX314 deleted the 2092-no-progress-for-wait-cmd branch October 24, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make --no-progress flag available to zarf tools wait-for
3 participants