Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix numbers in package templates #2076

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Conversation

Racer159
Copy link
Contributor

Description

Fix issues where the template regex does not match that of constants and variables.

Related Issue

Fixes #2074

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit fe6b21f
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/652d944e8f602100080059d1

Copy link
Contributor

@Noxsios Noxsios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ty @YrrepNoj ❤️

@Racer159 Racer159 merged commit 7801b7c into main Oct 16, 2023
@Racer159 Racer159 deleted the 2074-fix-templates-with-numbers branch October 16, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better handling of package templates with numeric names
2 participants