Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow shasums to be present in images #2028

Merged
merged 18 commits into from
Sep 30, 2023
Merged

Allow shasums to be present in images #2028

merged 18 commits into from
Sep 30, 2023

Conversation

Racer159
Copy link
Contributor

Description

This allows shasum references to work with Zarf by swapping the crane tag parsing code with the docker library.

Related Issue

Fixes #1221

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Sep 25, 2023 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 441924d
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/65184014cd6a2a00082a5c9b

@Racer159 Racer159 added the needs-tests PR Label - Tests required to merge label Sep 25, 2023
@Racer159 Racer159 marked this pull request as draft September 25, 2023 14:57
@Racer159 Racer159 marked this pull request as ready for review September 25, 2023 19:03
@Racer159 Racer159 removed the needs-tests PR Label - Tests required to merge label Sep 25, 2023
Noxsios
Noxsios previously approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@Noxsios Noxsios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm

@Racer159 Racer159 merged commit b3cb69e into main Sep 30, 2023
@Racer159 Racer159 deleted the hotfix-allow-shasums-in-images branch September 30, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noxsios Noxsios Noxsios approved these changes

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

@cmwylie19 cmwylie19 Awaiting requested review from cmwylie19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Impossible to deploy Zarf package when image includes image digests (@sha256:12...ef)
2 participants
@Racer159 @Noxsios