Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust timeout messaging to be more correct on timeout errors with 0 retries #2012

Merged
merged 4 commits into from
Sep 17, 2023

Conversation

Racer159
Copy link
Contributor

Description

This fixes an issue where the timeout message wouldn't show if retries was set to 0.

Related Issue

Fixes #N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 704ad74
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/65075a38f1e5bc00075b312e
😎 Deploy Preview https://deploy-preview-2012--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Noxsios Noxsios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, for anyone who may be confused like I was at first:

In go break and continue can optionally use a label to change the code execution order of nested loops.

retryCmd: creates essentially a named for-loop that break and continue can interact with, restarting/ending the loop as desired.

@Noxsios Noxsios merged commit a1e386a into main Sep 17, 2023
@Noxsios Noxsios deleted the hotfix-timeout-messaging branch September 17, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants