Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential for double transform of images (i.e with operators that self-reference) #1989

Merged
merged 10 commits into from
Aug 28, 2023
Merged

Fix potential for double transform of images (i.e with operators that self-reference) #1989

merged 10 commits into from
Aug 28, 2023

Conversation

cmwylie19
Copy link
Contributor

@cmwylie19 cmwylie19 commented Aug 25, 2023 •
edited
Loading

Description

Checks if image.Host has already been patched

Related Issue

Fixes #1988

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Aug 25, 2023 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit a9a037f
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/64ecea66b6539100081fdab5

cmwylie19 and others added 4 commits August 25, 2023 17:39
@Racer159 Racer159 changed the title 1988 Fix potential for double transform of images (i.e with operators that self-reference) Aug 26, 2023
Racer159
Racer159 requested changes Aug 26, 2023
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but this should probably be unit tested.

src/pkg/transform/image.go Outdated Show resolved Hide resolved
@Racer159 Racer159 added the needs-tests PR Label - Tests required to merge label Aug 26, 2023
@cmwylie19 cmwylie19 removed the needs-tests PR Label - Tests required to merge label Aug 27, 2023
@cmwylie19
Copy link
Contributor Author

@Racer159 I took the needs test label off because I think i have covered the newly implemented logic in image_test.go. LMK if you would like to see changes.

@cmwylie19
image logic simplication
8d351b4 
Signed-off-by: Case Wylie <[email protected]>
@Racer159 Racer159 self-requested a review August 28, 2023 15:54
Racer159
Racer159 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Racer159 Racer159 merged commit c5a9df4 into main Aug 28, 2023
@Racer159 Racer159 deleted the 1988 branch August 28, 2023 19:35
@renovate renovate bot mentioned this pull request Feb 27, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Racer159 Racer159 Racer159 approved these changes

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

@Noxsios Noxsios Awaiting requested review from Noxsios

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zarf image mutation happens twice in some scenarios
2 participants
@cmwylie19 @Racer159