Ensure Zarf image manifests are pulled as blobs #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UncleGedd
requested review from
jeff-mccoy,
cmwylie19,
Racer159 and
Noxsios
as code owners
✅ Deploy Preview for zarf-docs canceled.
|
UncleGedd
changed the title
|
Confirmed that I can now deploy bundles containing packages from GHCR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When pulling from GHCR we noticed that Zarf image manifests were coming from the
/manifests/path when they should actually be coming from/blobs/. Even though they are technically image manifests, Zarf stores in them OCI as blobs, so this PR changes the MediaType on the image manifest to be a Zarf blob