Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw warning instead of error when default CLIVersion is used when validating last non-breaking version #1981

Merged
merged 6 commits into from
Aug 25, 2023

Conversation

lucasrod16
Copy link
Contributor

@lucasrod16 lucasrod16 commented Aug 21, 2023

Description

Print a warning rather than return an error when an invalid CLIVersion is used when validating last non-breaking version

Related Issue

Fixes #1972

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist before merging

@netlify
Copy link

netlify bot commented Aug 21, 2023

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit d2734dc
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/64e7eea2fa2ec90008b13723

src/pkg/packager/common.go Outdated Show resolved Hide resolved
@lucasrod16 lucasrod16 changed the title Ignore default CLIVersion when validating last non-breaking version Throw warning instead of error when default CLIVersion is used when validating last non-breaking version Aug 23, 2023
@lucasrod16 lucasrod16 requested a review from Racer159 August 23, 2023 18:16
cmwylie19
cmwylie19 previously approved these changes Aug 23, 2023
Copy link
Contributor

@cmwylie19 cmwylie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/pkg/packager/common.go Outdated Show resolved Hide resolved
src/config/lang/english.go Outdated Show resolved Hide resolved
src/pkg/packager/common.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very close though would rather this nil return not be there

src/pkg/packager/common.go Outdated Show resolved Hide resolved
@Racer159 Racer159 merged commit d77690e into main Aug 25, 2023
@Racer159 Racer159 deleted the 1972-ignore-unset-cliVersion branch August 25, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when deploying v0.28.4 of init pkg using library Zarf
3 participants