-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw warning instead of error when default CLIVersion is used when validating last non-breaking version #1981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasrod16
requested review from
jeff-mccoy,
cmwylie19,
Racer159 and
Noxsios
as code owners
August 21, 2023 21:35
✅ Deploy Preview for zarf-docs canceled.
|
Racer159
requested changes
Aug 22, 2023
lucasrod16
changed the title
Ignore default CLIVersion when validating last non-breaking version
Throw warning instead of error when default CLIVersion is used when validating last non-breaking version
Aug 23, 2023
cmwylie19
previously approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Racer159
requested changes
Aug 23, 2023
Co-authored-by: Wayne Starr <[email protected]>
Racer159
requested changes
Aug 24, 2023
Racer159
requested changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very close though would rather this nil return not be there
Co-authored-by: Wayne Starr <[email protected]>
Racer159
approved these changes
Aug 25, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Print a warning rather than return an error when an invalid CLIVersion is used when validating last non-breaking version
Related Issue
Fixes #1972
Type of change
Checklist before merging