Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for validatePackageArchitecture() method #1957

Merged
merged 14 commits into from
Aug 10, 2023
Merged

Add unit test for validatePackageArchitecture() method #1957

merged 14 commits into from
Aug 10, 2023

Conversation

lucasrod16
Copy link
Contributor

Description

  • Replaces use of the concrete *kubernetes.Clientset implementation with the kubernetes.Interface for client operations for easier mocking/testing

  • Adds unit test for validatePackageArchitecture() method

Related Issue

Relates to #1750

Type of change

  • Other (security config, docs update, etc)

Checklist before merging

feat: Add unit test for validatePackageArchitecture() method
d4a9889 
Use the Kubernetes Interface for client operations for easier mocking/testing
@netlify
Copy link

netlify bot commented Aug 7, 2023 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 30cf429
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/64d4ede1f211160008c8b287

@lucasrod16 lucasrod16 marked this pull request as draft August 8, 2023 19:46
Lucas Rodriguez added 5 commits August 8, 2023 15:41
@lucasrod16 lucasrod16 marked this pull request as ready for review August 9, 2023 19:34
Racer159
Racer159 requested changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few changes, but overall looks good!

src/internal/packager/helm/chart.go Outdated Show resolved Hide resolved
src/pkg/k8s/version.go Outdated Show resolved Hide resolved
src/pkg/packager/deploy.go Show resolved Hide resolved
Racer159
Racer159 approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Racer159 Racer159 merged commit 8d5d9d8 into main Aug 10, 2023
@Racer159 Racer159 deleted the validatePackageArchitecture-unit-test branch August 10, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Racer159 Racer159 Racer159 approved these changes

@mike-winberry mike-winberry Awaiting requested review from mike-winberry

@Noxsios Noxsios Awaiting requested review from Noxsios

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

@cmwylie19 cmwylie19 Awaiting requested review from cmwylie19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasrod16 @Racer159