Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return images as an array of strings for all components #1927

Merged
merged 6 commits into from
Aug 2, 2023
Merged

Conversation

cmwylie19
Copy link
Contributor

Description

Users using library code can benefit from receiving a list of images . This was a feature request from the community. This provides users with the ability to pre-cache/pre-download images.

Related Issue

Fixes #1918

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Jul 28, 2023

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit f2ffecf
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/64c99637cc331d000883d058

src/pkg/packager/prepare.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Racer159 Racer159 enabled auto-merge (squash) August 1, 2023 23:33
@Racer159 Racer159 merged commit 910846e into main Aug 2, 2023
@Racer159 Racer159 deleted the 1918 branch August 2, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zarf prepare findImages method should return the string of images not only printing them to stdout.
3 participants