Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix named port #1894

Merged
merged 10 commits into from
Jul 10, 2023
Merged

Fix named port #1894

merged 10 commits into from
Jul 10, 2023

Conversation

cmwylie19
Copy link
Contributor

@cmwylie19 cmwylie19 commented Jul 7, 2023

Description

Looks for the container port on the pod with name corresponding to the targetPort on the service. Fixes named port issue

Related Issue

Fixes #1693

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

cmwylie19 and others added 6 commits July 6, 2023 10:05
…fd3084 (#1825)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[aws-actions/configure-aws-credentials](https://togithub.com/aws-actions/configure-aws-credentials)
| action | digest | `5727f24` -> `5fd3084` |

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the
Dependency Dashboard for more information.

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/defenseunicorns/zarf).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTcuMyIsInVwZGF0ZWRJblZlciI6IjM1LjE0NC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Wayne Starr <[email protected]>
## Description

Creates a `pending` ADR for initial work on `zarf bundle`.

## Related Issue

Relates to #1711

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------

Signed-off-by: razzle <[email protected]>
Co-authored-by: Wayne Starr <[email protected]>
Co-authored-by: Casey Wylie <[email protected]>
@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 4b6de87
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/64ac71d700aadd00080e46f5

@cmwylie19 cmwylie19 marked this pull request as ready for review July 8, 2023 12:18
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving (for now) since the test will be in #1853

@Racer159 Racer159 enabled auto-merge (squash) July 10, 2023 21:15
@Racer159 Racer159 merged commit bfaf5af into main Jul 10, 2023
@Racer159 Racer159 deleted the 1693 branch July 10, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zarf connect does not work for named ports
3 participants