-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --no-color option to disable color output #1889
Conversation
✅ Deploy Preview for zarf-docs canceled.
|
I created this as a draft MR in order to get feed back on this note |
Replying to this comment @caesarshift left on the issue: #890 (comment) The colored log message that says where we're loading the config file from is happening in the That If we want to make it so the log message for which config file is being used follows the same configuration as the rest of the logs, we could just move this line to after we have called |
Based on your comment, I've added a follow-on commit that moves the print statements into the cli setup (moving it into the function preserves the order of the output to precede the current log level output) |
b06ddd8
to
8bf0fc8
Compare
e1d9ff9
to
765fad0
Compare
FYSA, due to a merge conflict in src/config/config.go, I also rebased the branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This reverts commit 54faf90.
d317b05
to
3ee13b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Add --no-color option to disable color output
Related Issue
Fixes #890
Type of change
Checklist before merging