Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include empty files on package creation #1860

Merged
merged 6 commits into from
Jun 28, 2023
Merged

include empty files on package creation #1860

merged 6 commits into from
Jun 28, 2023

Conversation

YrrepNoj
Copy link
Contributor

@YrrepNoj YrrepNoj commented Jun 27, 2023 •
edited
Loading

fixes #1791

@netlify
Copy link

netlify bot commented Jun 27, 2023 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 23b5556
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/649c9a4f04938000081b9565

Noxsios
Noxsios reviewed Jun 27, 2023
View reviewed changes
src/pkg/utils/io.go Outdated Show resolved Hide resolved
Racer159
Racer159 approved these changes Jun 27, 2023
View reviewed changes
src/pkg/utils/io.go Outdated Show resolved Hide resolved
src/pkg/utils/io.go Outdated Show resolved Hide resolved
Racer159
Racer159 requested changes Jun 27, 2023
View reviewed changes
src/pkg/utils/io.go Outdated Show resolved Hide resolved
@YrrepNoj YrrepNoj requested a review from Madeline-UX as a code owner June 28, 2023 19:43
Racer159
Racer159 requested changes Jun 28, 2023
View reviewed changes
src/pkg/utils/io.go Outdated Show resolved Hide resolved
Racer159
Racer159 approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Racer159 Racer159 enabled auto-merge (squash) June 28, 2023 20:48
@Racer159 Racer159 merged commit e9a91e8 into main Jun 28, 2023
@Racer159 Racer159 deleted the 1791-including-empty-files branch June 28, 2023 21:09
@Racer159 Racer159 mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noxsios Noxsios Noxsios left review comments

@Racer159 Racer159 Racer159 approved these changes

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

@Madeline-UX Madeline-UX Awaiting requested review from Madeline-UX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty files under the files key don't get put into the package
3 participants
@YrrepNoj @Racer159 @Noxsios