Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add only filter support and init package removal by package name #1855

Merged
merged 19 commits into from
Jun 29, 2023
Merged

Add only filter support and init package removal by package name #1855

merged 19 commits into from
Jun 29, 2023

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented Jun 27, 2023 •
edited
Loading

Description

This adds only filter support to zarf package remove as well as allowing removal of init packages by their .tar.zst

Related Issue

Fixes: #1859
Fixes: #1839

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Jun 27, 2023 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit b40d5da
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/649dcd4cbaa2e500087599e3

@Racer159 Racer159 added the needs-tests PR Label - Tests required to merge label Jun 28, 2023
@Racer159
Copy link
Contributor Author

Added needs-tests since this should have a final init package remove step at the very end now that that is possible.

@Racer159 Racer159 removed the needs-tests PR Label - Tests required to merge label Jun 28, 2023
@Racer159 Racer159 mentioned this pull request Jun 28, 2023
Closed
YrrepNoj
YrrepNoj previously approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@YrrepNoj YrrepNoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a nit comment up to you.

src/pkg/packager/components.go Outdated Show resolved Hide resolved
@Racer159 Racer159 merged commit 72eba0c into main Jun 29, 2023
@Racer159 Racer159 deleted the make-remove-more-robust branch June 29, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YrrepNoj YrrepNoj YrrepNoj approved these changes

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

@Noxsios Noxsios Awaiting requested review from Noxsios

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Racer159 @YrrepNoj