Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not check composed filepath #1758

Merged
merged 4 commits into from
Jun 1, 2023
Merged

Do not check composed filepath #1758

merged 4 commits into from
Jun 1, 2023

Conversation

Noxsios
Copy link
Contributor

@Noxsios Noxsios commented May 30, 2023

Related Issue

Fixes #1756

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@Noxsios Noxsios linked an issue May 30, 2023 that may be closed by this pull request
Package create time relative path issues using imports #1756
Closed
@netlify
Copy link

netlify bot commented May 30, 2023 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit c26db99
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6477ac4feb12eb00087edb71

@Racer159 Racer159 marked this pull request as ready for review May 31, 2023 19:26
Noxsios
Noxsios commented May 31, 2023
View reviewed changes
Copy link
Contributor Author

@Noxsios Noxsios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Noxsios Noxsios merged commit c681879 into main Jun 1, 2023
@Noxsios Noxsios deleted the 1756-package-create-time-relative-path-issues-using-imports branch June 1, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YrrepNoj YrrepNoj YrrepNoj approved these changes

@Racer159 Racer159 Racer159 approved these changes

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package create time relative path issues using imports
3 participants
@Noxsios @Racer159 @YrrepNoj