Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial variables display code #1682

Merged
merged 45 commits into from
Jun 22, 2023
Merged

Initial variables display code #1682

merged 45 commits into from
Jun 22, 2023

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented May 8, 2023 •
edited by barronstone
Loading

Description

This adds set variables to the package preview prompt

Related Issue

Fixes #1124

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented May 8, 2023 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit c3739fb
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6494cbbb16450c000861a85a

@Racer159 Racer159 added needs-tests PR Label - Tests required to merge needs-design ux labels May 8, 2023
Racer159 and others added 19 commits May 23, 2023 16:54
@Racer159
Initial package warnings section and unhide filtered components
3560985
@Racer159
Include warnings in packager instead
dd5f04b
@Racer159
Remove more erroneous passing of warnings
3b14022
@Racer159
Add more sugar
33e9eab
@Racer159
Merge branch 'main' into 1722-package-warnings-update
579f910
@Racer159
Update Note and SBOM displays to match newer designs
df1da4a
@Racer159
Move horizontalnoterule to match other warnings
01913f1
@Racer159
Resolve feedback and normalize all warnings
c35dba3
@Racer159
Add warnings as a named variable
6b9d3f8
@Racer159
Update to use normal warnf
5e78dca
@Racer159
Always print a newline before a warning like we do for NOTE
a9bdf0b
@Racer159
Add a title to package configuration
c257244
@Racer159
Fix error message in viper.go
6723c9d
@Racer159
Address issues with pointers
926a016
@Racer159
Merge branch 'main' into 1722-package-warnings-update
9db456d
@Racer159
Rename Error and Errorf to better reflect what they do
8fa54e3
@Racer159
Address #1751 as well
4bf6a89
@Racer159
Merge branch 'main' into 1124-package-preview-prompt-variables
1609eed
@Racer159
Update based on SBOMs/Warnings code
9f7b290
@Racer159 Racer159 requested a review from mike-winberry as a code owner May 25, 2023 18:47
@Racer159 Racer159 marked this pull request as draft May 30, 2023 19:41
@Racer159 Racer159 removed the needs-tests PR Label - Tests required to merge label Jun 22, 2023
@Racer159
Copy link
Contributor Author

This is what this looks like now:

image
image
image
image
image
image

@Racer159 Racer159 marked this pull request as ready for review June 22, 2023 20:36
@Racer159 Racer159 requested review from Madeline-UX and a team as code owners June 22, 2023 20:36
YrrepNoj
YrrepNoj previously approved these changes Jun 22, 2023
View reviewed changes
@Racer159 Racer159 enabled auto-merge (squash) June 22, 2023 22:59
@Racer159 Racer159 merged commit 32d13a5 into main Jun 22, 2023
@Racer159 Racer159 deleted the 1124-package-preview-prompt-variables branch June 22, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YrrepNoj YrrepNoj YrrepNoj approved these changes

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

@Noxsios Noxsios Awaiting requested review from Noxsios

@mike-winberry mike-winberry Awaiting requested review from mike-winberry

@Madeline-UX Madeline-UX Awaiting requested review from Madeline-UX

Assignees
No one assigned
Labels
ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Declared variables not reflected in package preview prompt
2 participants
@Racer159 @YrrepNoj