Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Big Bang YOLO mode support #1681

Merged
merged 5 commits into from
May 17, 2023
Merged

Add Big Bang YOLO mode support #1681

merged 5 commits into from
May 17, 2023

Conversation

willswire
Copy link
Contributor

@willswire willswire commented May 8, 2023

Description

Add Big Bang YOLO mode support

Related Issue

Addresses #1670

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented May 8, 2023

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 10cc81a
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/646421b0d1e24d0007b26199
😎 Deploy Preview https://deploy-preview-1681--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

src/extensions/bigbang/manifests.go Outdated Show resolved Hide resolved
packages/zarf-registry/registry-values.yaml Outdated Show resolved Hide resolved
@willswire willswire requested a review from Racer159 May 8, 2023 20:52
@willswire willswire marked this pull request as draft May 8, 2023 20:56
@willswire
Copy link
Contributor Author

willswire commented May 8, 2023

using this repo to test against compiled version with changes. so far can verify working package creation and deployment on local cluster

embedded working example in the examples/big-bang-yolo-mode folder of this MR

src/extensions/bigbang/manifests.go Outdated Show resolved Hide resolved
@willswire willswire requested a review from Racer159 May 9, 2023 19:49
@willswire willswire changed the title Draft: Add Big Bang YOLO mode support Add Big Bang YOLO mode support May 11, 2023
@willswire willswire marked this pull request as ready for review May 11, 2023 04:27
@willswire willswire requested a review from Madeline-UX as a code owner May 11, 2023 04:27
Racer159
Racer159 previously approved these changes May 16, 2023
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@willswire
Copy link
Contributor Author

willswire commented May 16, 2023

rebased w/ signed commits

@willswire willswire requested a review from Racer159 May 16, 2023 23:20
@Racer159
Copy link
Contributor

There are still some commits in the middle that aren't signed (if needed we can open a new PR and sign - maintaining your authorship)
image

@willswire
Copy link
Contributor Author

willswire commented May 17, 2023

There are still some commits in the middle that aren't signed (if needed we can open a new PR and sign - maintaining your authorship)
image

I force-pushed signed commits over those - it should go thru

Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving, we'll see! (GH may be being weird with what it shows there - usually old commits disappear)

Copy link
Contributor

@Noxsios Noxsios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Racer159 Racer159 merged commit 7d496fd into zarf-dev:main May 17, 2023
@willswire willswire deleted the bigbang-yolo-mode branch May 17, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants