-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zarf walkthrough update #1601
Zarf walkthrough update #1601
Conversation
✅ Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
I think linking init as a pre-req is fine and we can just focus on create/deploy. IMO the dos-games video should likely be updated to include both create and deploy and more closely match the walkthrough. (also there are merge conflicts on this branch that need to be resolved) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small suggestions.
Co-authored-by: Wayne Starr <[email protected]>
I have thought about this some - I think if we were to provide the game as pre-built (on release page) it could all be in one. I struggle with the walkthrough being build and deploy because for a lot of users those tasks will be separate. Although I know package creators will deploy to test. I think the bigger issue is the dos games is an example package. So this should really be how to build a package and how to deploy a package (general steps for packages) |
Add docker as a pre-req Co-authored-by: Wayne Starr <[email protected]>
…zarf into zarf-walkthrough-update
just changed "the" to "a"
I agree though I think I'd like to see #758 done first to really build that out - we have the dos games available via sget but this is not likely to be something that most people use as the OCI functionality is much easier for most to use. |
Description
See comments section for some questions/requested feedback
...
Related Issue
Fixes #
Relates to #
Type of change
Checklist before merging