Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer explicitly check for deprecated text in the upgrade test #1546

Merged
merged 1 commit into from
Apr 3, 2023
Merged

No longer explicitly check for deprecated text in the upgrade test #1546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/test/upgrade-test/previously_built_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ func TestPreviouslyBuiltZarfPackage(t *testing.T) {
stdOut, stdErr, err := exec.Cmd(zarfBinPath, zarfDeployArgs...)
require.NoError(t, err, stdOut, stdErr)

// [DEPRECATIONS] We expect the older package to contain the deprecations
require.Contains(t, stdErr, "Component 'test-upgrade-package' is using setVariable")
// [DEPRECATIONS] We expect any deprecated things to work from the old package
require.Contains(t, stdErr, "Successfully deployed podinfo 6.3.4")
require.Contains(t, stdErr, "-----BEGIN PUBLIC KEY-----")

Expand All @@ -59,8 +58,7 @@ func TestPreviouslyBuiltZarfPackage(t *testing.T) {
stdOut, stdErr, err = exec.Cmd(zarfBinPath, zarfDeployArgs...)
require.NoError(t, err, stdOut, stdErr)

// [DEPRECATIONS] We expect the newer package to have been migrated
require.NotContains(t, stdErr, "Component 'test-upgrade-package' is using setVariable")
// [DEPRECATIONS] We expect any deprecated things to work from the new package
require.Contains(t, stdErr, "Successfully deployed podinfo 6.3.5")
require.Contains(t, stdErr, "-----BEGIN PUBLIC KEY-----")

Expand Down