Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with Windows dataInjections #1520

Merged
merged 12 commits into from
Mar 31, 2023
Merged

Fix issues with Windows dataInjections #1520

merged 12 commits into from
Mar 31, 2023

Conversation

Racer159
Copy link
Contributor

Description

This selects the correct shell on Windows for dataInjections.

Related Issue

Fixes #1513

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Mar 30, 2023 •
edited
Loading

✅ Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit d2b5b2d
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/642707338b280b00086522a1
😎 Deploy Preview https://deploy-preview-1520--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Racer159 Racer159 requested a review from a team as a code owner March 30, 2023 23:46
YrrepNoj
YrrepNoj previously approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@YrrepNoj YrrepNoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a small nit, but it's more of a personal preference thing and not something I would prevent from merging in.

src/internal/cluster/data.go Outdated Show resolved Hide resolved
src/internal/cluster/data.go Outdated Show resolved Hide resolved
Racer159
Racer159 commented Mar 31, 2023
View reviewed changes
src/internal/cluster/data.go Outdated Show resolved Hide resolved
src/internal/cluster/data.go Outdated Show resolved Hide resolved
@Racer159 Racer159 enabled auto-merge (squash) March 31, 2023 16:17
@Racer159 Racer159 merged commit 77c1342 into main Mar 31, 2023
@Racer159 Racer159 deleted the 1513-data-injection-on-windows branch March 31, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YrrepNoj YrrepNoj YrrepNoj approved these changes

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

@Madeline-UX Madeline-UX Awaiting requested review from Madeline-UX

@JasonvanBrackel JasonvanBrackel Awaiting requested review from JasonvanBrackel

@wirewc wirewc Awaiting requested review from wirewc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data Injection - Windows Support
2 participants
@Racer159 @YrrepNoj