Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge valuesFrom with BigBang compose #1477

Merged
merged 9 commits into from
Mar 30, 2023
Merged

Merge valuesFrom with BigBang compose #1477

merged 9 commits into from
Mar 30, 2023

Conversation

runyontr
Copy link
Contributor

Description

When using a zarf.yaml to extend an existing bigbang definition like:

components:
  - name: cocowow
    required: true
    import:
      path: ../defense-unicorns-distro
      name: bigbang
    extensions:
      bigbang:
        version: "###ZARF_PKG_VAR_BIGBANG_VERSION###"
        valuesFiles:
        # look at imports and then merging here for composition
        - ../values/authservice.yaml
        - ../values/keycloak.yaml

Zarf ignores the provided values files in this zarf.yaml

Related Issue

Relates to #1060

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Mar 24, 2023

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 0060e99
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6425ce00ccd26700086767dc

YrrepNoj
YrrepNoj previously approved these changes Mar 24, 2023
src/pkg/packager/compose.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good 'nuf

@Racer159 Racer159 enabled auto-merge (squash) March 30, 2023 19:00
@Racer159 Racer159 merged commit 24eef4d into main Mar 30, 2023
@Racer159 Racer159 deleted the bb-merge-values branch March 30, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants