Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1445 bugs in package pull and package publish #1446

Merged
merged 6 commits into from
Mar 17, 2023
Merged

1445 bugs in package pull and package publish #1446

merged 6 commits into from
Mar 17, 2023

Conversation

Noxsios
Copy link
Contributor

@Noxsios Noxsios commented Mar 17, 2023

Fixes #1445

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Noxsios added 4 commits March 16, 2023 20:00
@Noxsios
only include sboms.tar if it exists
036b761 
Signed-off-by: razzle <[email protected]>
@Noxsios
fix pull
dbb4c66 
Signed-off-by: razzle <[email protected]>
@Noxsios
update tests
c01566d 
Signed-off-by: razzle <[email protected]>
@Noxsios
update tests
21904ce 
Signed-off-by: razzle <[email protected]>
@Noxsios Noxsios linked an issue Mar 17, 2023 that may be closed by this pull request
Bugs in package pull and package publish #1445
Closed
@netlify
Copy link

netlify bot commented Mar 17, 2023 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit ae52ab5
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6414168f3624550008e7df9a

@Noxsios Noxsios marked this pull request as ready for review March 17, 2023 19:25
@Noxsios Noxsios marked this pull request as draft March 17, 2023 19:29
@Noxsios Noxsios marked this pull request as ready for review March 17, 2023 19:30
Racer159
Racer159 approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Racer159 Racer159 merged commit b29bcdc into main Mar 17, 2023
@Racer159 Racer159 deleted the 1445-bugs-in-package-pull-and-package-publish branch March 17, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Racer159 Racer159 Racer159 approved these changes

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

@YrrepNoj YrrepNoj Awaiting requested review from YrrepNoj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bugs in package pull and package publish
2 participants
@Noxsios @Racer159