Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update progress bar message #1441

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

nik-don
Copy link
Contributor

@nik-don nik-don commented Mar 16, 2023

Description

The commit swaps the message in the title variable to show the current bytes pulled in the progress bar instead of the expected total bytes. This improves the clarity of the message for the user.

#1439

Related Issue

Fixes #1439

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

The commit swaps the message in the `title` variable to show the current bytes pulled in the progress bar instead of the expected total bytes. This improves the clarity of the message for the user.

zarf-dev#1439
@netlify
Copy link

netlify bot commented Mar 16, 2023

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit a507e15
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6413a260d138b000080cc75b

Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but will require 2 person review from @YrrepNoj or @jeff-mccoy

Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Racer159 Racer159 merged commit c09891b into zarf-dev:main Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image pull logs total / downloaded instead of downloaded / total GBs
3 participants