deletes tar.zst of components after unarchive #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wirewc
requested review from
jeff-mccoy,
YrrepNoj and
Racer159
as code owners
5 tasks
YrrepNoj
approved these changes
Feb 27, 2023
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
## Description Upon a successful unarchive, delete the `tar.zst` that is no longer needed when using `zarf tools archiver decompress <package> <dest> --decompress-all`. ... Before behavior: ``` ocipkg/ ├── components │ ├── keyval │ │ └── manifests │ │ └── k3s │ │ ├── hornstash-deploy.yaml │ │ └── zarf-service.yaml │ └── keyval.tar.zst ├── images.tar ├── sboms │ ├── compare.html │ ├── registry.gitlab.com_buzzdeploy_apps_horn-stash_main-amd64.json │ └── sbom-viewer-registry.gitlab.com_buzzdeploy_apps_horn-stash_main-amd64.html ├── zarf-1135963779 └── zarf.yaml ``` After: ``` ocipkg/ ├── components │ └── keyval │ └── manifests │ └── k3s │ ├── hornstash-deploy.yaml │ └── zarf-service.yaml ├── images.tar ├── sboms │ ├── compare.html │ ├── registry.gitlab.com_buzzdeploy_apps_horn-stash_main-amd64.json │ └── sbom-viewer-registry.gitlab.com_buzzdeploy_apps_horn-stash_main-amd64.html ├── zarf-1135963779 └── zarf.yaml ``` ## Related Issue Fixes # ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [ ] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed
Racer159
pushed a commit
that referenced
this pull request
Mar 8, 2023
Upon a successful unarchive, delete the `tar.zst` that is no longer needed when using `zarf tools archiver decompress <package> <dest> --decompress-all`. ... Before behavior: ``` ocipkg/ ├── components │ ├── keyval │ │ └── manifests │ │ └── k3s │ │ ├── hornstash-deploy.yaml │ │ └── zarf-service.yaml │ └── keyval.tar.zst ├── images.tar ├── sboms │ ├── compare.html │ ├── registry.gitlab.com_buzzdeploy_apps_horn-stash_main-amd64.json │ └── sbom-viewer-registry.gitlab.com_buzzdeploy_apps_horn-stash_main-amd64.html ├── zarf-1135963779 └── zarf.yaml ``` After: ``` ocipkg/ ├── components │ └── keyval │ └── manifests │ └── k3s │ ├── hornstash-deploy.yaml │ └── zarf-service.yaml ├── images.tar ├── sboms │ ├── compare.html │ ├── registry.gitlab.com_buzzdeploy_apps_horn-stash_main-amd64.json │ └── sbom-viewer-registry.gitlab.com_buzzdeploy_apps_horn-stash_main-amd64.html ├── zarf-1135963779 └── zarf.yaml ``` Fixes # - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) - [ ] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed
Racer159
pushed a commit
that referenced
this pull request
Mar 8, 2023
Upon a successful unarchive, delete the `tar.zst` that is no longer needed when using `zarf tools archiver decompress <package> <dest> --decompress-all`. ... Before behavior: ``` ocipkg/ ├── components │ ├── keyval │ │ └── manifests │ │ └── k3s │ │ ├── hornstash-deploy.yaml │ │ └── zarf-service.yaml │ └── keyval.tar.zst ├── images.tar ├── sboms │ ├── compare.html │ ├── registry.gitlab.com_buzzdeploy_apps_horn-stash_main-amd64.json │ └── sbom-viewer-registry.gitlab.com_buzzdeploy_apps_horn-stash_main-amd64.html ├── zarf-1135963779 └── zarf.yaml ``` After: ``` ocipkg/ ├── components │ └── keyval │ └── manifests │ └── k3s │ ├── hornstash-deploy.yaml │ └── zarf-service.yaml ├── images.tar ├── sboms │ ├── compare.html │ ├── registry.gitlab.com_buzzdeploy_apps_horn-stash_main-amd64.json │ └── sbom-viewer-registry.gitlab.com_buzzdeploy_apps_horn-stash_main-amd64.html ├── zarf-1135963779 └── zarf.yaml ``` Fixes # - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) - [ ] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upon a successful unarchive, delete the
tar.zstthat is no longer needed when usingzarf tools archiver decompress <package> <dest> --decompress-all....
Before behavior:
After:
Related Issue
Fixes #
Type of change
Checklist before merging